Skip to content

Change Element#halfLifeSeconds from long to double - #5122

Merged
gustovafing merged 1 commit into
GregTechCEu:1.20.1from
MCTian-mi:double-half-lives
Aug 6, 2026
Merged

Change Element#halfLifeSeconds from long to double#5122
gustovafing merged 1 commit into
GregTechCEu:1.20.1from
MCTian-mi:double-half-lives

Conversation

@MCTian-mi

@MCTian-mi MCTian-mi commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What

As the titles says, changes all references to halfLiveSeconds from long to double.

  • No AI driven tools were used for this pull request.
  • Yes AI driven tools were used for this pull request.

@MCTian-mi
MCTian-mi requested a review from a team as a code owner July 17, 2026 05:32
@YoungOnionMC

Copy link
Copy Markdown
Member

how come this needs to be a double, the api is currently unused internally, just for sub second decay rates?

@MCTian-mi

Copy link
Copy Markdown
Contributor Author

how come this needs to be a double, the api is currently unused internally, just for sub second decay rates?

Also some elements have half lives longer than Long.MAX_VALUE. And I think it's overall ok to use double over long since it's we would never need it to be that precise.

@YoungOnionMC YoungOnionMC added type: feature New feature or request bundled for a 0.X.0 Update Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels Aug 6, 2026
@gustovafing
gustovafing enabled auto-merge (squash) August 6, 2026 08:35
@gustovafing
gustovafing merged commit afa406a into GregTechCEu:1.20.1 Aug 6, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. type: feature New feature or request bundled for a 0.X.0 Update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants